-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 use markdown for rendering grouped text wraps / TAS-782 #4402
Open
sophiamersmann
wants to merge
2
commits into
master
Choose a base branch
from
markdown-text-wrap-group
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiamersmann
changed the title
🔨 use markdown for rendering grouped text wraps
🔨 use markdown for rendering grouped text wraps / TAS-782
Jan 8, 2025
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 851 (af1e14) ❌ Edited: 2025-01-13 10:12:35 UTC |
sophiamersmann
force-pushed
the
scatter-axis-labels-viz
branch
from
January 9, 2025 11:59
84e6485
to
0f6ed49
Compare
sophiamersmann
force-pushed
the
markdown-text-wrap-group
branch
from
January 9, 2025 11:59
7a1dd77
to
8ce1f76
Compare
sophiamersmann
force-pushed
the
scatter-axis-labels-viz
branch
from
January 9, 2025 12:52
0f6ed49
to
d95a8ab
Compare
sophiamersmann
force-pushed
the
markdown-text-wrap-group
branch
from
January 9, 2025 12:52
8ce1f76
to
54f3e88
Compare
sophiamersmann
force-pushed
the
scatter-axis-labels-viz
branch
from
January 9, 2025 15:09
d95a8ab
to
721caf1
Compare
sophiamersmann
force-pushed
the
markdown-text-wrap-group
branch
from
January 9, 2025 15:09
54f3e88
to
ea07fb3
Compare
sophiamersmann
force-pushed
the
scatter-axis-labels-viz
branch
from
January 13, 2025 09:50
721caf1
to
a5479f3
Compare
sophiamersmann
force-pushed
the
markdown-text-wrap-group
branch
from
January 13, 2025 09:50
ea07fb3
to
3521d4d
Compare
sophiamersmann
force-pushed
the
markdown-text-wrap-group
branch
2 times, most recently
from
January 13, 2025 14:25
f40c06a
to
03ad582
Compare
sophiamersmann
force-pushed
the
markdown-text-wrap-group
branch
3 times, most recently
from
January 13, 2025 14:42
591b9a6
to
73e796d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of
TextWrapGroup
and instead uses theMarkdownTextWrap
component to implement similar behaviour.I want to use the 'avoid-wrap' behaviour for axis labels and their units, but axis labels support DoDs, so I need Markdown rendering.
This is part 2 of 4 in a stack made with GitButler: